Fixed #9533 - Position: positioning within document raises error #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meyertee Can you sign our CLA so we can review this? Thanks. |
|
@tjvantoll done! |
| expect( 7 ); | ||
|
|
||
| collisionTest({ | ||
| within : document |
There was a problem hiding this comment.
No space before the colon, same thing for the next two.
|
I addressed @jzaefferer's comments and squashed. Thanks. |
|
Thank you and sorry for taking too long to do the amendments myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #9533
Added a unit test raising the error & added an isDoc boolean to withinInfo to avoid calling css( "overflow-x" ) on document.
Note that the error isn't raised when css( "overflow-x" ) is called on another element earlier. So the test may not fail when running all unit tests. It does fail when only running 'tests/unit/position/position.html'
http://bugs.jqueryui.com/ticket/9533